Skip to content

Add constants for termios ioctls #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2017
Merged

Add constants for termios ioctls #636

merged 1 commit into from
Jul 2, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Jul 1, 2017

These should be c_int from what I could see for Linux and I assumed the others were the same.

@alexcrichton
Copy link
Member

Looks like CI may be failing?

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 1, 2017

Indeed, evidently i forgot how to write out octal literals.

This actually brings up a question I had, but never asked: should I try to preserve constants in their original base where possible? For example I used octal when defining these constants on NetBSD and family because that's how they're written in their source files, though these values are actually identical across every platform. Was this the right approach? I haven't seen a comment on any of my PRs stating a preference one way or another, but I know for the winapi crate, the maintainer prefers keeping things looking similar.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 2, 2017

Alright, this should be GTG!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 2, 2017

📌 Commit 82dc2f3 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 2, 2017

⌛ Testing commit 82dc2f3 with merge 1af26db...

bors added a commit that referenced this pull request Jul 2, 2017
@bors
Auto merge of #636 - Susurrus:termios_ioctl, r=alexcrichton
1af26db 
Add constants for termios ioctls

These should be `c_int` from what I could see for Linux and I assumed the others were the same.
@bors
Copy link
Contributor

bors commented Jul 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1af26db to master...

@bors bors merged commit 82dc2f3 into rust-lang:master Jul 2, 2017
@Susurrus Susurrus deleted the termios_ioctl branch July 2, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Susurrus @alexcrichton @bors