Rework --check-cfg generation comment
#13195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
ca8959d to
2dafb34
Compare
weihanglo
approved these changes
Dec 22, 2023
|
Awesome. Love seeing people adding informative comments :) @bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2023
Update cargo 7 commits in 363a2d11320faf531f6aacd1ea067c6bc08343b9..ac6bbb33293d8d424c17ecdb42af3aac25fb7295 2023-12-22 03:12:42 +0000 to 2023-12-26 23:22:08 +0000 - docs: fix link to nightly doc of cargo-util-schemas (rust-lang/cargo#13209) - doc: improve word usage (rust-lang/cargo#13206) - fix: clarify `--path` is the installation source not destination (rust-lang/cargo#13205) - refactor: give some better examples for package ID spec (rust-lang/cargo#13202) - chore: fix a typo (rust-lang/cargo#13201) - Extend the build directive syntax with `cargo::` (rust-lang/cargo#12201) - Rework `--check-cfg` generation comment (rust-lang/cargo#13195) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2023
Update cargo 7 commits in 363a2d11320faf531f6aacd1ea067c6bc08343b9..ac6bbb33293d8d424c17ecdb42af3aac25fb7295 2023-12-22 03:12:42 +0000 to 2023-12-26 23:22:08 +0000 - docs: fix link to nightly doc of cargo-util-schemas (rust-lang/cargo#13209) - doc: improve word usage (rust-lang/cargo#13206) - fix: clarify `--path` is the installation source not destination (rust-lang/cargo#13205) - refactor: give some better examples for package ID spec (rust-lang/cargo#13202) - chore: fix a typo (rust-lang/cargo#13201) - Extend the build directive syntax with `cargo::` (rust-lang/cargo#12201) - Rework `--check-cfg` generation comment (rust-lang/cargo#13195) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something related to
--check-cfg, I looked back at this comment and realized it could be improved, so here is my PR improving it.