Skip to content

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 22, 2023

What does this PR try to resolve?

resolver-tests was run a separate job but accidentally included in #12342. This PR excludes it again.

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@weihanglo
Copy link
Member Author

Blocked on #12539 bumping the version of cargo.

@weihanglo
Copy link
Member Author

Ready to merge now.

@epage
Copy link
Contributor

epage commented Aug 22, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 22, 2023

📌 Commit f9920c2 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit f9920c2 with merge 33db9be...

bors added a commit that referenced this pull request Aug 22, 2023
ci: test `resolver-tests` in a separate job
@bors
Copy link
Contributor

bors commented Aug 22, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2023
@epage
Copy link
Contributor

epage commented Aug 22, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@weihanglo
Copy link
Member Author

Hmm... I completely don't know what this failure is 😞.

   Compiling foo v0.0.1 (D:\a\cargo\cargo\target\tmp\cit\t1079\foo)
     Running `rustc --crate-name foo src\main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 -C metadata=f9e88282337cd66d -C extra-filename=-f9e88282337cd66d --out-dir D:\a\cargo\cargo\target\tmp\cit\t1079\foo\target\custom-bin-target\debug\deps --target \\?\D:\a\cargo\cargo\target\tmp\cit\t1079\foo\custom-bin-target.json -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1079\foo\target\custom-bin-target\debug\deps -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1079\foo\target\debug\deps`
error: linking with `rust-lld` failed: exit code: 0xc0000374
  |
  = note: "rust-lld" "-flavor" "gnu" "D:\\a\\cargo\\cargo\\target\\tmp\\cit\\t1079\\foo\\target\\custom-bin-target\\debug\\deps\\foo-f9e88282337cd66d.foo.b337eb6238b88ab8-cgu.0.rcgu.o" "--as-needed" "-L" "D:\\a\\cargo\\cargo\\target\\tmp\\cit\\t1079\\foo\\target\\custom-bin-target\\debug\\deps" "-L" "D:\\a\\cargo\\cargo\\target\\tmp\\cit\\t1079\\foo\\target\\debug\\deps" "-L" "C:\\Users\\runneradmin\\.rustup\\toolchains\\nightly-x86_64-pc-windows-gnu\\lib\\rustlib\\custom-bin-target\\lib" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "C:\\Users\\runneradmin\\.rustup\\toolchains\\nightly-x86_64-pc-windows-gnu\\lib\\rustlib\\custom-bin-target\\lib" "-o" "D:\\a\\cargo\\cargo\\target\\tmp\\cit\\t1079\\foo\\target\\custom-bin-target\\debug\\deps\\foo-f9e88282337cd66d" "--gc-sections"
  = note: rust-lld: warning: cannot find entry symbol _start; not setting start address

@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit f9920c2 with merge e7ebf96...

bors added a commit that referenced this pull request Aug 22, 2023
ci: test `resolver-tests` in a separate job
@bors
Copy link
Contributor

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing e7ebf96 to master...

@bors
Copy link
Contributor

bors commented Aug 22, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@weihanglo
Copy link
Member Author

Poor PR

@bors retry

@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit f9920c2 with merge 43585c1...

@bors
Copy link
Contributor

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 43585c1 to master...

@bors bors merged commit 43585c1 into rust-lang:master Aug 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2023
Update cargo

3 commits in 80eca0e58fb2ff52c1e94fc191b55b37ed73e0e4..2cc50bc0b63ad20da193e002ba11d391af0104b7
2023-08-19 00:52:06 +0000 to 2023-08-22 22:43:08 +0000
- config: merge lists in precedence order (rust-lang/cargo#12515)
- ci: test `resolver-tests` in a separate job (rust-lang/cargo#12540)
- refactor: Use clap to suggest alternative argument for unsupported arguments (rust-lang/cargo#12529)

r? ghost
@ehuss ehuss added this to the 1.74.0 milestone Oct 11, 2023
@weihanglo weihanglo deleted the resolver-tests branch March 29, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants