Skip to content

fix: Pass CI on nightly #12160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

fix: Pass CI on nightly #12160

merged 1 commit into from
May 19, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented May 19, 2023

It appears rustc is now giving warnings when calling drop on Copy types (drop-copy)

@epage
fix: Pass CI on nightly
7c7abfe 
It appears rustc is now giving warnings when calling `drop` on `Copy`
types (`drop-copy`)
@rustbot
Copy link
Collaborator

rustbot commented May 19, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2023
@weihanglo
Copy link
Member

Thought it was fixed by #12136 🤔

Anyway thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 19, 2023

📌 Commit 7c7abfe has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2023
@bors
Copy link
Contributor

bors commented May 19, 2023

⌛ Testing commit 7c7abfe with merge 2015080...

@epage
Copy link
Contributor Author

epage commented May 19, 2023

Also seeing these failures locally

    plugins::panic_abort_plugins
    plugins::plugin_to_the_max
    plugins::plugin_with_dynamic_native_dependency
    plugins::shared_panic_abort_plugins

as it can't find rustc_driver and rustc_ast crates.

@ehuss
Copy link
Contributor

ehuss commented May 19, 2023

I'm curious what's going on here. I'm not able to reproduce on rustc 1.71.0-nightly (d3f416dc0 2023-05-18) on the latest master 46b83f4. Can you say which rustc version you have?

@bors
Copy link
Contributor

bors commented May 19, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 2015080 to master...

@bors bors merged commit 2015080 into rust-lang:master May 19, 2023
@epage
Copy link
Contributor Author

epage commented May 19, 2023

Same nightly. Oddly enough, its gone away. Unsure what happened.

@epage epage deleted the nightly branch May 19, 2023 20:34
@weihanglo weihanglo mentioned this pull request May 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2023
@bors
Auto merge of rust-lang#111890 - weihanglo:update-cargo, r=weihanglo
edbd5c5 
Update cargo

10 commits in 09276c703a473ab33daaeb94917232e80eefd628..64fb38c97ac4d3a327fc9032c862dd28c8833b17
2023-05-16 21:43:35 +0000 to 2023-05-23 18:53:23 +0000
- Consider rust-version when selecting packages for cargo add (rust-lang/cargo#12078)
- fix(lints): Switch to -Zlints so stable projects can experiment (rust-lang/cargo#12168)
- Automatically inherit workspace fields when running cargo new/init (rust-lang/cargo#12069)
- ci: check if any version bump needed for member crates (rust-lang/cargo#12126)
- feat: `lints` feature (rust-lang/cargo#12148)
- fix: pass `-C debuginfo` after weakening if explicitly set (rust-lang/cargo#12165)
- Tweak build help to clarify role of --bin (rust-lang/cargo#12157)
- fix: Pass CI on nightly (rust-lang/cargo#12160)
- docs(source): doc comments for Source and its impls (rust-lang/cargo#12159)
- docs(source): doc comments for `Source` and friends (rust-lang/cargo#12153)

r? `@ghost`
saethlin pushed a commit to saethlin/miri that referenced this pull request May 26, 2023
@bors
Auto merge of #111890 - weihanglo:update-cargo, r=weihanglo
e5ca77b 
Update cargo

10 commits in 09276c703a473ab33daaeb94917232e80eefd628..64fb38c97ac4d3a327fc9032c862dd28c8833b17
2023-05-16 21:43:35 +0000 to 2023-05-23 18:53:23 +0000
- Consider rust-version when selecting packages for cargo add (rust-lang/cargo#12078)
- fix(lints): Switch to -Zlints so stable projects can experiment (rust-lang/cargo#12168)
- Automatically inherit workspace fields when running cargo new/init (rust-lang/cargo#12069)
- ci: check if any version bump needed for member crates (rust-lang/cargo#12126)
- feat: `lints` feature (rust-lang/cargo#12148)
- fix: pass `-C debuginfo` after weakening if explicitly set (rust-lang/cargo#12165)
- Tweak build help to clarify role of --bin (rust-lang/cargo#12157)
- fix: Pass CI on nightly (rust-lang/cargo#12160)
- docs(source): doc comments for Source and its impls (rust-lang/cargo#12159)
- docs(source): doc comments for `Source` and friends (rust-lang/cargo#12153)

r? `@ghost`
@ehuss ehuss added this to the 1.71.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-build-execution Area: anything dealing with executing the compiler S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@epage @rustbot @weihanglo @bors @ehuss