[beta-1.68] Backport fixes #11674
Merged
[beta-1.68] Backport fixes #11674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Eh2406 Do not error for `auth-required: true` without `-Z sparse-registry` Registries that include `auth-required: true` in their `config.json` currently hit the following error on stable: ``` authenticated registries require `-Z registry-auth` ``` This situation makes it difficult for a registry to optionally offer the `auth-required: true` feature, since it forces users on to the nightly toolchain. This PR changes the behavior to ignore the `auth-required: true` field of `config.json` without `-Z registry-auth`. The downside to this change is that it makes it harder to discover why a registry isn't working, since the user will get an HTTP 401 error from the server, rather than a message from Cargo suggesting adding `-Z registry-auth`. r? `@Eh2406`
Verify source before recompile
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
|
|
@rust-lang/cargo any objection or concern? |
|
This is able to be merged, as the CI error in nightly has been fixed. |
|
@bors r+ |
|
💔 Test failed - checks-actions |
My mistake 😅. Need to wait one more day. |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Feb 9, 2023
1 commits in 0762e3bbdb6fa64b6859154199ec47d6c90c731c..ddf05ad7a66f4cfbe79d7692b84aa144c1aac34d 2023-01-30 22:07:51 +0000 to 2023-02-09 03:13:43 +0000 - [beta-1.68] Backport fixes (rust-lang/cargo#11674)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2023
…nglo [beta-1.68] cargo beta backports 1 commits in 0762e3bbdb6fa64b6859154199ec47d6c90c731c..ddf05ad7a66f4cfbe79d7692b84aa144c1aac34d 2023-01-30 22:07:51 +0000 to 2023-02-09 03:13:43 +0000 - [beta-1.68] Backport fixes (rust-lang/cargo#11674) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backports:
auth-required: truewithout-Z registry-auth#11661 — Do not error forauth-required: truewithout-Z sparse-registry