Skip to content

Conversation

Diomendius
Copy link
Contributor

@Diomendius Diomendius commented Jul 1, 2022

This is a backport of #10810 to the rust-1.63.0 branch. src/etc/_cargo is unchanged between this branch and master and only Zsh cares about the contents of this file, so there should be no issues with merging this.

The zsh tab-completion script had missing line continuations which would
cause `command not found:` errors when trying to complete the
`cargo add` or `cargo locate-project` subcommands.
@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.63.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@weihanglo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 1, 2022

📌 Commit 9766342 has been approved by weihanglo

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2022
@bors
Copy link
Contributor

bors commented Jul 1, 2022

⌛ Testing commit 9766342 with merge fd9c429...

@bors
Copy link
Contributor

bors commented Jul 1, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing fd9c429 to rust-1.63.0...

@bors bors merged commit fd9c429 into rust-lang:rust-1.63.0 Jul 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2022
[beta] Beta 1.63 backports

* fix data race in thread::scope rust-lang#98503
* Mitigate MMIO stale data vulnerability rust-lang#98126
* Cargo:
    * [BETA-1.63] Fix zsh completions for add and locate-project (rust-lang/cargo#10811)
    * [BETA-1.63] Bump cargo-util version. (rust-lang/cargo#10805)
@ehuss ehuss added this to the 1.63.0 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants