Sign container images with cosign #7119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to securely verify that a Qdrant container image was created by us
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
reviewed
Aug 25, 2025
Comment on lines
+59
to
+61
|
|
||
| DIGEST=$(docker buildx imagetools inspect ${DOCKERHUB_TAG} --format '{{ json .Manifest.Digest }}' | cut -d '"' -f 2) | ||
| cosign sign --yes "${DOCKERHUB_TAG}@${DIGEST}" |
There was a problem hiding this comment.
Is it correct that we sign after pushing the image? Then, where is the signature kept?
There was a problem hiding this comment.
Yes, this is correct. The docker tag includes the registry host, and cosign attaches the signature for us.
timvisee
approved these changes
Aug 25, 2025
timvisee
pushed a commit
that referenced
this pull request
Aug 26, 2025
* Sign container images with cosign This allows users to securely verify that a Qdrant container image was created by us * Add contents read permission
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to securely verify that a Qdrant container image was created by us
Once merged and after the next release, a container image can be verified like this:
All the details: https://docs.sigstore.dev/cosign/signing/signing_with_containers/
All Submissions:
devbranch. Did you create your branch fromdev?