In proxy segment, don't return deleted point versions #7109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More specifically, don't return a point version from the wrapped segment if that point is already marked for deletion within the proxy.
In some places we rely on
point_version
to tell us if (and what) point (version) exists in a segment. When a proxy segment marks a wrapped point for deletion, we should not expose its point version anymore.The old behavior broke the following places (and potentially others):
qdrant/lib/collection/src/collection_manager/holders/segment_holder.rs
Line 395 in 5ffe70d
qdrant/lib/collection/src/collection_manager/holders/segment_holder.rs
Line 564 in 5ffe70d
I'm currently still evaluating if stuff around this code is also sound.
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?