Skip to content

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Aug 20, 2025

More specifically, don't return a point version from the wrapped segment if that point is already marked for deletion within the proxy.

In some places we rely on point_version to tell us if (and what) point (version) exists in a segment. When a proxy segment marks a wrapped point for deletion, we should not expose its point version anymore.

The old behavior broke the following places (and potentially others):

I'm currently still evaluating if stuff around this code is also sound.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

More specifically, don't return a point version from the wrapped segment
if that point is already marked for deletion within the proxy.
@timvisee timvisee requested a review from agourlay August 20, 2025 16:04

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@timvisee timvisee requested review from generall and Copilot August 21, 2025 08:37
Copilot

This comment was marked as resolved.

@timvisee timvisee force-pushed the proxy-segment-point-version-deleted branch from 8c020b0 to 62917a7 Compare August 21, 2025 13:21
@timvisee timvisee force-pushed the proxy-segment-point-version-deleted branch from 62917a7 to 9ecba02 Compare August 21, 2025 13:25
@agourlay agourlay merged commit e02d3dc into dev Aug 21, 2025
16 checks passed
@agourlay agourlay deleted the proxy-segment-point-version-deleted branch August 21, 2025 13:48
timvisee added a commit that referenced this pull request Aug 26, 2025
* In proxy segment, don't return deleted point versions

More specifically, don't return a point version from the wrapped segment
if that point is already marked for deletion within the proxy.

* Do get wrapped segment point version if it's newer than soft delete

* Flatten function
@timvisee timvisee mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants