Skip to content

In payload indices, make storage non optional #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 14, 2025
Merged

In payload indices, make storage non optional #7041

merged 8 commits into from
Aug 14, 2025

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Aug 12, 2025 •
edited
Loading

Make storage structures non-optional, it is now always loaded.

See #6999 for more details.

Tasks

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee mentioned this pull request Aug 12, 2025
Merged
7 tasks
This was referenced Aug 12, 2025
Merged
Merged
coszio
coszio approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:feelsgood:

@timvisee timvisee force-pushed the payload-index-single-stage-load-remove-load branch from c9643c8 to a9e1562 Compare August 13, 2025 15:38
@timvisee timvisee force-pushed the payload-index-single-stage-load-simplify-internals branch from a23cab2 to e005d2e Compare August 13, 2025 15:40
Base automatically changed from payload-index-single-stage-load-remove-load to dev August 14, 2025 07:18
@timvisee timvisee force-pushed the payload-index-single-stage-load-simplify-internals branch from e005d2e to d13117e Compare August 14, 2025 07:19
@timvisee timvisee marked this pull request as ready for review August 14, 2025 07:19
@coderabbitai coderabbitai

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@timvisee timvisee merged commit 0deb1a4 into dev Aug 14, 2025
16 checks passed
@timvisee timvisee deleted the payload-index-single-stage-load-simplify-internals branch August 14, 2025 07:52
timvisee added a commit that referenced this pull request Aug 14, 2025
@timvisee
In payload indices, make storage non optional (#7041)
cfaab01 
* Make numeric index storage non optional

* Make map index storage non optional

* Make full text index storage non optional

* Remove unnecessary option

* Make geo index storage non optional

* Make bool index storage non optional

* Remove unnecessary result

* Make null index storage non optional
@coderabbitai coderabbitai bot mentioned this pull request Aug 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@coszio coszio coszio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Simplify payload index internals
Development

Successfully merging this pull request may close these issues.
2 participants
@timvisee @coszio