Skip to content

Add buffer_size_b to on_disk #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

Add buffer_size_b to on_disk #6993

merged 2 commits into from
Aug 7, 2025

Conversation

nibblerenush
Copy link
Contributor

Fix this issue: #6956

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

An optional configuration parameter, buffer_size_bytes, was added to the logging configuration in config/config.yaml with a default value of 1024 bytes. The Config struct in src/tracing/on_disk.rs was extended with an optional buffer_size_bytes field, and its merge method was updated to merge this field from another instance. The buffered writer in the new_layer function now uses io::BufWriter::with_capacity with the buffer size set to this parameter or defaults to 8192 bytes if not specified. Test cases in src/tracing/test.rs were modified to include and verify the new buffer_size_bytes field in the logger configuration JSON inputs and expected outputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbf4a31 and 9a4717a.

📒 Files selected for processing (3)
  • config/config.yaml (2 hunks)
  • src/tracing/on_disk.rs (3 hunks)
  • src/tracing/test.rs (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • src/tracing/test.rs
  • config/config.yaml
  • src/tracing/on_disk.rs
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@generall generall requested a review from ffuugoo August 6, 2025 21:13
ffuugoo
ffuugoo requested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@ffuugoo ffuugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd only ask to rename buffer_size_b to buffer_size_bytes

ffuugoo
ffuugoo approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@ffuugoo ffuugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🎉

timvisee
timvisee reviewed Aug 7, 2025
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check for us what behavior is like when you set the buffer size to 0 or 1 bytes?

@nibblerenush
Copy link
Contributor Author

nibblerenush commented Aug 7, 2025 •
edited
Loading

Could you check for us what behavior is like when you set the buffer size to 0 or 1 bytes?

I use the following configuration:

logger:
  # Logging format, supports `text` and `json`
  format: text
  on_disk:
    enabled: true
    log_file: qdrant.log
    log_level: TRACE
    # Logging format, supports `text` and `json`
    format: text
    buffer_size_bytes: <0 or 1>

In both cases, the expected behavior is observed, the qdrant does not fail, the information is written to the log file

timvisee
timvisee approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timvisee timvisee merged commit 2cd230d into qdrant:dev Aug 7, 2025
16 checks passed
@nibblerenush
Copy link
Contributor Author

nibblerenush commented Aug 7, 2025 •
edited
Loading

Thanks for the opportunity!

@nibblerenush nibblerenush deleted the add_buffer_size_b branch August 7, 2025 12:08
timvisee pushed a commit that referenced this pull request Aug 11, 2025
@nibblerenush @timvisee
Add buffer_size_b to on_disk (#6993)
10254d7 
* Add buffer_size_b to on_disk

* Rename buffer_size_b to buffer_size_bytes
@timvisee timvisee mentioned this pull request Aug 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

@ffuugoo ffuugoo ffuugoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nibblerenush @timvisee @ffuugoo