Cleanup versions on segment repair #6975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
I think we originally had this behavior to still use partially persisted points when replaying the WAL. It was previously possible to CoW a point to an appendable segment, while only flushing the the deletion from the original segment. We've revisited the segment flush order since, always flushing appendable segments first now. I agree that this change seems sound now, and cannot think of a problematic situation. |
timvisee
approved these changes
Aug 5, 2025
Merged
timvisee
pushed a commit
that referenced
this pull request
Aug 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently cleanup version after replaying WAL, but we should be cleaning them up BEFORE we reapply operations.
There is currently a problem where WAL replay would assign
version=Some(0)to points which hadversion=None. If we cleanup versions before the replay, we don't need to worry about this