Fix resharding dead replicas improvements #6881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
349eec4 to
07d6bfb
Compare
07d6bfb to
a9f4869
Compare
timvisee
approved these changes
Jul 16, 2025
3 tasks
KShivendu
added a commit
that referenced
this pull request
Jul 16, 2025
…esharding (#6800) * Fix bug that causes all replicas to die if node is restarted during resharding * fix recursive async problem * Avoid write lock unless required * avoid using &mut when & is sufficient * Remove is_in_progress since check_abort_resharding exists (#6806) * On resharding abort, only abort transfers related to current operation * Fix resharding dead replicas improvements (#6881) * Apply suggestions to fix resharding dead replicas * fmt --------- Co-authored-by: timvisee <tim@visee.me>
generall
pushed a commit
that referenced
this pull request
Jul 17, 2025
…esharding (#6800) * Fix bug that causes all replicas to die if node is restarted during resharding * fix recursive async problem * Avoid write lock unless required * avoid using &mut when & is sufficient * Remove is_in_progress since check_abort_resharding exists (#6806) * On resharding abort, only abort transfers related to current operation * Fix resharding dead replicas improvements (#6881) * Apply suggestions to fix resharding dead replicas * fmt --------- Co-authored-by: timvisee <tim@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements discussed with @timvisee to existing PR #6800. Created a separate PR so I can test images in my CM test
Note: These changes also highlight the larger effect of the PR since this
abort_shard_transfer_and_reshardingis called at multiple places. We should be careful about it and think more carefully if it can break anything.Update: CI is failing because of #6859 and 2nd one because of not being able to fetch web UI. 1st one needs rebase and 2nd one should be resolved by re-triggering CI. Will do!All Submissions:
devbranch. Did you create your branch fromdev?