add flag to break optimization loop on panic #6787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if optimization panics, we can stuck in the loop of failures.
This PR should fix (improve) the endless loop problem.
Actual problem is
Which re-tries optimization unconditionally, even if permit was dropped because of panic.
What this PR does:
on_release
->on_manual_release
, to prevent triggering of the callback if permit was destroyed on error. Only explicit release for permission change counts nowBehavior after PR: