Create new custom shards in Initializing
state instead of Active
#6778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, new custom shards are initialized directly in
Active
state. In this case peer A (that did not receive custom shard replica) might expect replica to already exist on peer B, but peer B might still be initializing local replica of new custom shard. This leads to annoying errors during search while custom shard is being created.This PR tries to mitigate this by initializing replicas in
Inititalizing
state (so that each peer would not assume that remote replicas are instantly available) and then switching each replica intoActive
state after it's initialized.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: