remove max indexing threads from config #6760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
timvisee
approved these changes
Jun 26, 2025
I would argue that we don't want this functionality to be adjustable anymore |
generall
added a commit
that referenced
this pull request
Jul 17, 2025
* remove max_optimization_threads from config.yaml * fmt
|
in the release, it says max_indexing_threads is deprecated, but in the PR can see max_optimization_threads are removed from config. Are these linked? should we use optimizer_cpu_budget for indexing threads also? |
It is
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two reasons for it:
option is obsolete and there are no cases to use it anymore. It's functionality is completely replaces by
optimizer_cpu_budgetthis option might be confusing, as its name overlaps with per-collection configuration, which have different semantics and different behavior for 0 value
remove max_optimization_threads from config.yaml
fmt