Fix Chinese stopwords #6765
Merged
Fix Chinese stopwords #6765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
approved these changes
Jun 26, 2025
606b840
into
implement_new_multilingual_tokenizer
17 checks passed
generall
added a commit
that referenced
this pull request
Jun 26, 2025
* Implement new multilingual tokenizer * Remove unnecessary clones * Codespell * filter stopwords before stemmer * Fix Chinese stopwords (#6765) * Fix Chinese stopwords * remove todo --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
generall
added a commit
that referenced
this pull request
Jul 17, 2025
* Implement new multilingual tokenizer * Remove unnecessary clones * Codespell * filter stopwords before stemmer * Fix Chinese stopwords (#6765) * Fix Chinese stopwords * remove todo --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6762
This PR removes pinyin conversion (eg 中国 => ["zhong", "guo"]) in our new multilingual tokenizer implementation. This fixes Chinese stopwords, because the tokens were in pinyin but our stopword list is written with Chinese letters (so basically we did
assert!(["是", "上去", ...].contains("shì")))Since Pinyin is just the romanized phonetic version of a Chinese word, we can use the original Chinese word without loosing information about the word. We even improve precision, because multiple Chinese words can map to the same Pinyin, e.g. 忘记 and 旺季 is both
["wang", "ji"](https://www.quora.com/Is-pinyin-romanization-a-bijective-map).