Enable pod role based auth for s3 snapshots #6757
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -60,8 +61,13 @@ impl SnapshotStorageManager { | |||
| Ok(SnapshotStorageManager::LocalFS(SnapshotStorageLocalFS)) | |||
| } | |||
| SnapshotsStorageConfig::S3 => { | |||
| let mut builder = AmazonS3Builder::new(); | |||
| if let Some(s3_config) = &snapshots_config.s3_config { | |||
| let builder = if let Some(s3_config) = &snapshots_config.s3_config { | |||
There was a problem hiding this comment.
Possibly could just replace AmazonS3Builder::new with AmazonS3Builder::from_env method, but not sure if there are cases where this would not be desirable behavior.
There was a problem hiding this comment.
I cannot think of a case where we would not want to source details from the environment. Let's remove with_env from our config, and always use from_env.
If this ever becomes an issue in the future, we can always add the config option back.
|
I ran |
|
For posterity: we tested this internally and it definitely works for our use case, thank you for the quick turnaround. |
|
Awesome. Thanks for giving it a shot! And thanks for the straight-to-the-point PR. |
|
Good news! We've just released Qdrant 1.15. It includes this change. |
|
Wonderful, thank you! |
We'd like to be able to run back-ups from EKS pods that use role based authentication to our S3 buckets. To support this, it seems qdrant must use the AmazonS3Builder::from_env method to populate the builder with information from the environment per this feature request from the object-store library.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: