check if we try to deactivate last initializing replica #6755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
timvisee
approved these changes
Jun 25, 2025
Co-authored-by: Tim Visée <tim+github@visee.me>
ffuugoo
approved these changes
Jun 25, 2025
9 tasks
generall
added a commit
that referenced
this pull request
Jul 17, 2025
* check if we try to deactivate last initializing replica * consider more cases * Update lib/collection/src/shards/replica_set/mod.rs Co-authored-by: Tim Visée <tim+github@visee.me> --------- Co-authored-by: Tim Visée <tim+github@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug, which I can't reproduce locally, but it was observed on practice multiple times:
If pod was somehow killed during collection creation or there was an error during creating a collection (due to file descriptors or something like that), it might be possible that some shards of the collection have inconsistent state between
initializinganddead.Local shard thinks the shard is
deadwhile other machines in the cluster consider itinitializing.Since local shard status it
deadit needs to recover it from somewhere, but it is also the only shard in the cluster. So cluster is stuck in this inconsistent state without ability to recover (except for collection deletion).This PR extends our check for
is_last_active_replicaand handles the case of no active replicas in more details.