-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add mutable full text payload index on top of Gridstore #6639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0972557
to
6488bdd
Compare
2a9250c
to
01be8db
Compare
01be8db
to
87a1cec
Compare
timvisee
commented
Jun 5, 2025
lib/segment/src/index/field_index/full_text_index/text_index.rs
Outdated
Show resolved
Hide resolved
6ff6d87
to
e2427fa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
54533d6
to
cc72368
Compare
12 tasks
coszio
approved these changes
Jun 5, 2025
This was referenced Jul 8, 2025
generall
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Implement clear cache for immutable text index * Add Gridstore backend for mutable full text payload index * Add mutable full text payload index builder for Gridstore * Fix compilation error * Add tests * Extract mutable inverted index builder to standalone type * Return generic error in Gridstore iterator * Remove intermediate buffer from Gridstore load, load index directly * Minor fixes * Remove TODO, no good solution * Fix review remarks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6634
Similar to #6634, this implements Gridstore as alternative storage backend for a payload index. This implements it for the full text index.
Tasks
dev
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: