Add volatile dense vector storage, use in tests #6561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
commented
May 20, 2025
Comment on lines
+6
to
+7
| #[cfg(test)] | ||
| pub mod volatile_dense_vector_storage; |
There was a problem hiding this comment.
New storage is marked with #[cfg(test)] so that we cannot use it in a release build.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
9 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
approved these changes
May 21, 2025
9 tasks
generall
pushed a commit
that referenced
this pull request
May 22, 2025
* Add volatile dense vector storage * Use volatile dense vector storage in tests * Fix compilation error in GPU module * Simplify constructor * Use volatile storage in more tests
n0x29a
pushed a commit
that referenced
this pull request
May 23, 2025
* Add volatile dense vector storage * Use volatile dense vector storage in tests * Fix compilation error in GPU module * Simplify constructor * Use volatile storage in more tests
This was referenced Jun 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new dense vector storage type. The storage is volatile, being purely in memory, and is intended for use in testing.
This brings us a tiny step closer to fully removing RocksDB from our code base.
We were using the RocksDB based dense vector storage as baseline in many of our tests. It must be replaced so that RocksDB can be removed at some point.
It is possible to replace them with the appendable mmap storage. However, I prefer this volatile storage because it is much simpler and doesn't require any IO.
If we deem this acceptable, I'll also implement this for other storage types if necessary.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?