Skip to content

Add setting to limit max number of collections #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

Add setting to limit max number of collections #6548

merged 3 commits into from
May 20, 2025

Conversation

generall
Copy link
Member

@generall generall commented May 19, 2025 •
edited
Loading 

QDRANT__STORAGE__MAX_COLLECTIONS=1000

@coderabbitai coderabbitai

This comment was marked as resolved.

Sign in to view
@generall generall requested a review from agourlay May 19, 2025 19:10
@timvisee timvisee changed the title add setting to limit max number of colelctions Add setting to limit max number of collections May 20, 2025
timvisee
timvisee approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I also added the property to the configuration (null). If you don't like it, you can drop the last commit 😃

@agourlay
Copy link
Member

Can we somehow test this with the consensus test infra by passing the env. variable?

@generall
Copy link
Member Author

Can we somehow test this with the consensus test infra by passing the env. variable?

Tested manually, works as expected, assuming that QDRANT__STORAGE__MAX_COLLECTIONS value is the same on all nodes

@generall generall merged commit dc203e1 into dev May 20, 2025
24 of 25 checks passed
@generall generall deleted the max-number-of-collections branch May 20, 2025 11:40
generall added a commit that referenced this pull request May 22, 2025
@generall @timvisee
Add setting to limit max number of collections (#6548)
3501e4b 
* add setting to limit max number of colelctions

* upd openapi

* Add max_collections to config

---------

Co-authored-by: timvisee <tim@visee.me>
n0x29a pushed a commit that referenced this pull request May 23, 2025
@generall @timvisee @n0x29a
Add setting to limit max number of collections (#6548)
8cbab27 
* add setting to limit max number of colelctions

* upd openapi

* Add max_collections to config

---------

Co-authored-by: timvisee <tim@visee.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

@KShivendu KShivendu KShivendu approved these changes

@agourlay agourlay Awaiting requested review from agourlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@generall @agourlay @timvisee @KShivendu