Skip to content

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented May 16, 2025

This test was flaky at first, but this has now been fixed. The test is fully deterministic now. The failure cases were acceptable because the different index types behave a little bit different - that is expected.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee force-pushed the payload-index-full-text-congruence branch from 706ba6a to 9fed8e4 Compare May 16, 2025 09:35
@timvisee timvisee marked this pull request as ready for review May 19, 2025 09:15
@timvisee timvisee requested review from agourlay and Copilot May 19, 2025 09:15
Copilot

This comment was marked as resolved.

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@timvisee timvisee merged commit 6742e9b into dev May 19, 2025
24 of 25 checks passed
@timvisee timvisee deleted the payload-index-full-text-congruence branch May 19, 2025 10:48
generall pushed a commit that referenced this pull request May 22, 2025
* Add congruence test for full text payload index

* Report what index variants we're testing

* Use string references

* deterministic keywords

* linting

* Use truncate instead of drain

* Don't check cardinality on deletion, indices behave differently

* Include index type in iterator

* Fix test compilation

---------

Co-authored-by: Arnaud Gourlay <arnaud.gourlay@gmail.com>
n0x29a pushed a commit that referenced this pull request May 23, 2025
* Add congruence test for full text payload index

* Report what index variants we're testing

* Use string references

* deterministic keywords

* linting

* Use truncate instead of drain

* Don't check cardinality on deletion, indices behave differently

* Include index type in iterator

* Fix test compilation

---------

Co-authored-by: Arnaud Gourlay <arnaud.gourlay@gmail.com>
@coderabbitai coderabbitai bot mentioned this pull request Aug 27, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants