-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add in-memory payload index on mmap storage (geo) #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7ed774
to
08244e9
Compare
17294ad
to
b6d6d10
Compare
b6d6d10
to
2299219
Compare
This comment was marked as resolved.
This comment was marked as resolved.
generall
approved these changes
May 13, 2025
n0x29a
pushed a commit
that referenced
this pull request
May 14, 2025
* Add storage enum to geo index * Construct immutable geo index from mmap geo index * Load immutable geo index from mmap storage if on-disk is false * When immutable geo index is loaded into memory, clear mmap cache * Adjust immutable geo index from mmap loading, consider point deletions * Rename get_db_wrapper to db_wrapper * Add immutable mmap geo index test, currently still failing * Properly load geo index * Add congruence test * Also test with deletions * Fix clipping warnings
generall
pushed a commit
that referenced
this pull request
May 22, 2025
* Add storage enum to geo index * Construct immutable geo index from mmap geo index * Load immutable geo index from mmap storage if on-disk is false * When immutable geo index is loaded into memory, clear mmap cache * Adjust immutable geo index from mmap loading, consider point deletions * Rename get_db_wrapper to db_wrapper * Add immutable mmap geo index test, currently still failing * Properly load geo index * Add congruence test * Also test with deletions * Fix clipping warnings
6 tasks
12 tasks
This was referenced Jul 24, 2025
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6495.
Add in-memory payload index for geo points using mmap as storage.
Loading the in-memory full text payload index from mmap is 24x faster than from RocksDB, as shown in this simple benchmark:
bfb --geo-payloads -n 2000000 -d1 --indexing-threshold 100
:Tasks
dev
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: