Make reads sequential in BatchedVectorReader #6508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirming improvement on my HDD: Dev PR |
generall
approved these changes
May 9, 2025
19e5758
into
batch-reader-for-segment-construction
13 checks passed
generall
added a commit
that referenced
this pull request
May 9, 2025
* naive implementation of batched reader for segment construction * Make reads sequential in BatchedVectorReader (#6508) * Add sequential reads and improve BatchedVectorReader * implement get_many_sequential --------- Co-authored-by: generall <andrey@vasnetsov.com> * implement get_many_sequential --------- Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com>
generall
added a commit
that referenced
this pull request
May 22, 2025
* naive implementation of batched reader for segment construction * Make reads sequential in BatchedVectorReader (#6508) * Add sequential reads and improve BatchedVectorReader * implement get_many_sequential --------- Co-authored-by: generall <andrey@vasnetsov.com> * implement get_many_sequential --------- Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6487
Improves optimization when copying points from different segments into a new one.
Benchmark:
On the same machine with storage on a Hetzner Network Disk (5M points, 20=>10 segments, vectors on disk)
Dev: 200s
PR: 3s
SSH-FS mounted Hetzner Network Disk (100k points, 10=>5 segments, vectors on disk)
Dev: ~450s
PR: 240s