Don't batch queries if having more segments than search threads #6478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
approved these changes
May 1, 2025
|
How did you validate this change? |
|
Discovered another reason to not do mini-batching: assume we have very large on-disk collection, and we want to do a full-scan over it. It would be much faster if we go segment-by-segment, computing full batch of points right away. In this case we only need to load from disk once. |
generall
pushed a commit
that referenced
this pull request
May 22, 2025
* Don't batch query if there's more segments than CPUs, limit threads * Don't batch query if there's more segments than search threads * Link to pull request * Add note that we only consider local segments and global search threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6423 regression
Extension of #6326
While the condition change is not perfect, it does help significantly with the issue as described above.
This just prevents batching for a specific case that is known to perform bad: when having a high number of segments versus search threads.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?