Abort resharding after marking as dead #6394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
lib/collection/src/tests/points_dedup.rs:137
- [nitpick] Consider introducing a named constant or inline documentation for the literal 'false' parameter to clarify its purpose in the call to update_local.
.update_local(op, true, HwMeasurementAcc::new(), false)
lib/collection/src/shards/shard_holder/resharding.rs:333
- [nitpick] The literal 'true' passed into delete_local_points may benefit from a named constant or comment clarifying its semantic meaning, which can improve readability and maintainability.
.delete_local_points(filter, HwMeasurementAcc::disposable(), true) // Internal operation, no performance tracking needed
lib/collection/src/collection/mod.rs:464
- [nitpick] The repeated use of literal 'false' for aborting resharding might be made clearer by extracting it into a well-named constant to better convey its purpose in the control flow.
abort_resharding_result = self.abort_resharding(state.key(), false).await;
ffuugoo
reviewed
Apr 16, 2025
ffuugoo
approved these changes
Apr 16, 2025
ffuugoo
approved these changes
Apr 16, 2025
f3e0c73 to
eb78314
Compare
eb78314 to
faf71f8
Compare
This was referenced Apr 16, 2025
KShivendu
approved these changes
Apr 16, 2025
|
Thanks! Also doing extensive testing now. |
KShivendu
added a commit
that referenced
this pull request
Apr 16, 2025
* Abort resharding if any Resharding replica is to be marked dead * Abort resharding before marking shard as Dead * add comments * Abort resharding after marking as dead (#6394) * Force delete points when aborting resharding, even if replica is dead * Abort resharding after marking replica as dead * Only abort resharding if we mark related replica as dead * Just rely on shard replica state * Propagate shard transfer error right away --------- Co-authored-by: Tim Visée <tim+github@visee.me>
pull bot
pushed a commit
to kp-forks/qdrant
that referenced
this pull request
Apr 21, 2025
…nt#6364) * Abort resharding if any Resharding replica is to be marked dead * Abort resharding before marking shard as Dead * add comments * Abort resharding after marking as dead (qdrant#6394) * Force delete points when aborting resharding, even if replica is dead * Abort resharding after marking replica as dead * Only abort resharding if we mark related replica as dead * Just rely on shard replica state * Propagate shard transfer error right away --------- Co-authored-by: Tim Visée <tim+github@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes on top of #6364
The main things this solves is:
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?