Fix update wrapper #6383
Merged
Fix update wrapper #6383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This was referenced Apr 15, 2025
pull bot
pushed a commit
to kp-forks/qdrant
that referenced
this pull request
Apr 21, 2025
* fix flush routine for persistent wrappers * fmt * rollback changes for write-only wrappers * Use retain to drop flushed items * Rename function --------- Co-authored-by: timvisee <tim@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we had a broken flush procedure in all db wrappers.
Old logic does the following:
But, what if we read from the structure in the moment after flush thread created, but before it is actually written - we can have inconsistent results.
This PR: makes a copy of changes for the thread and only removes pending updates if they are persisted.