Mutable ID tracker: improve version flushing, grow file in one shot #6267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
7280d83 to
7e99c00
Compare
This comment has been minimized.
This comment has been minimized.
ffuugoo
approved these changes
Mar 28, 2025
18 tasks
coszio
approved these changes
Mar 28, 2025
timvisee
added a commit
that referenced
this pull request
Mar 31, 2025
…6267) * In mutable ID tracker, grow versions file in one shot * Fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #6157
An improvement to how we flush versions in the new mutable ID tracker.
With this PR we now check the required size for the versions file. If it isn't large enough to write new versions, we immediately grow it to allocate all required space with one syscall.
Previously, we just wrote new versions to the end of the file directly to automatically grow it. While that is fine, it can cause a lot of file re-allocations to progressively grow it in steps when writing new versions.
This now prevents that, and optimizes for that scenario.
In numbers, if we insert 10k new points, this reduces reallocating the file from 10 times to just once.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?