Skip to content

Check use_mutable_id_tracker_without_rocksdb feature flag when building new segment #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Check use_mutable_id_tracker_without_rocksdb feature flag when building new segment #6211

merged 1 commit into from
Mar 20, 2025

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Mar 20, 2025 •
edited by timvisee
Loading

Tracked in: #6157

Seems like we missed a feature flag check in one place when implementing MutableIdTracker.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo requested review from timvisee and generall March 20, 2025 16:20
timvisee
timvisee approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timvisee timvisee mentioned this pull request Mar 20, 2025
Closed
18 tasks
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2025

📝 Walkthrough

Walkthrough

The changes add conditional logic within the segment builder for initializing the ID tracker based on a feature flag. When the feature flag use_mutable_id_tracker_without_rocksdb is enabled, a mutable ID tracker is created; otherwise, a RocksDB-based tracker is instantiated. This update involves importing and utilizing the new create_rocksdb_id_tracker function and adjusting the control flow in the SegmentBuilder implementation to accommodate the conditional tracker creation without altering the overall structure.

Possibly related PRs

Suggested reviewers

  • agourlay
  • generall
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c283b00 and 2cd54d2.

📒 Files selected for processing (1)
  • lib/segment/src/segment_constructor/segment_builder.rs (3 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
lib/segment/src/segment_constructor/segment_builder.rs (2)
lib/common/common/src/flags.rs (1) (1)
  • feature_flags (38-46)
lib/segment/src/segment_constructor/segment_constructor_base.rs (2) (2)
  • create_mutable_id_tracker (353-355)
  • create_rocksdb_id_tracker (357-361)
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: test-shard-snapshot-api-s3-minio
  • GitHub Check: test-snapshot-operations-s3-minio
  • GitHub Check: test-low-resources
  • GitHub Check: test-consistency
  • GitHub Check: test-consensus-compose
  • GitHub Check: Basic TLS/HTTPS tests
  • GitHub Check: test-consensus
  • GitHub Check: test (macos-latest)
  • GitHub Check: test
  • GitHub Check: test (windows-latest)
  • GitHub Check: test
  • GitHub Check: test (ubuntu-latest)
  • GitHub Check: test
🔇 Additional comments (3)
lib/segment/src/segment_constructor/segment_builder.rs (3)

14-14: Added necessary import for feature flags check.

The import of feature_flags function from common::flags module is appropriate as it's required for the conditional logic implemented later in the code.

23-26: Import list properly updated to include create_rocksdb_id_tracker.

The import list has been correctly extended to include create_rocksdb_id_tracker, which is needed for the conditional logic that selects between different ID tracker implementations.

90-94: Feature flag check properly implemented for ID tracker selection.

The conditional logic now correctly checks the use_mutable_id_tracker_without_rocksdb feature flag to determine which ID tracker implementation to use. This change implements the missing check mentioned in the PR description and ensures the code behaves according to the configured feature flags.

When the feature flag is enabled, it creates a MutableIdTracker; otherwise, it uses a RocksDB-based SimpleIdTracker. This implementation is consistent with the feature flag's intent.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@timvisee timvisee merged commit 8b44f08 into dev Mar 20, 2025
17 checks passed
@timvisee timvisee deleted the segment-builder-use-mutable-id-tracker-feature-flag branch March 20, 2025 16:45
timvisee pushed a commit that referenced this pull request Mar 21, 2025
@ffuugoo @timvisee
Check use_mutable_id_tracker_without_rocksdb feature flag when buil…
03dc95c 
…ding new segment (#6211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

@generall generall Awaiting requested review from generall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffuugoo @timvisee