Fix consensus snapshot not applying resharding state #6210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
commented
Mar 20, 2025
| let State { | ||
| config, | ||
| shards, | ||
| resharding, |
There was a problem hiding this comment.
We totally missed handling resharding here. Struct destruction revealed the unused field.
This comment was marked as resolved.
This comment was marked as resolved.
KShivendu
approved these changes
Mar 20, 2025
ffuugoo
approved these changes
Mar 20, 2025
6 tasks
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Destruct struct when applying collection state * In consensus snapshot, apply resharding state
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resharding state in a consensus snapshot was simply not applied. This fixes the issue.
We've been seeing a wild range of resharding state errors in chaos testing, which we've yet to have an explanation for. I expect this to resolve all those problems.
A proper test for this will be done separately, as this is part of a wider effort fixing issues.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?