Mutable ID tracker: show warning if mapping and versions count mismatch #6207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
This comment was marked as resolved.
This comment was marked as resolved.
JojiiOfficial
approved these changes
Mar 20, 2025
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
…ch (#6207) * Add warning if mapping and version count mismatch, WAL should recover * Make log messages more consistent and concrete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #6157
Show a warning if the number of internal point mappings does not match with the number of versions. Their counts should normally be equal.
If a crash happens during flush, new versions may only be partially written or not at all. In such case we can expect the list of versions to be shorter.
This shows a warning to make us aware of this having happened, potentially allowing is to debug better. Under normal circumstances, the WAL should always recover this situation.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?