Skip to content

Do not rate limit resharding shard cleaning #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Do not rate limit resharding shard cleaning #6121

merged 1 commit into from
Mar 11, 2025

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented Mar 7, 2025 •
edited
Loading

This PR removes the check for write rate limits when cleaning up a shard after resharding.

It relies on detecting a disposable hardware counter like in #6118

@agourlay agourlay marked this pull request as ready for review March 10, 2025 11:32
@agourlay agourlay added this to the Rate limiting milestone Mar 10, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2025

📝 Walkthrough

Walkthrough

This pull request updates the rate limiting mechanism by incorporating hardware measurement context into the logic. Specifically, the functions responsible for write rate limiting in the shard replica set (i.e., check_write_rate_limiter and check_write_rate_limiter_lazy) now accept an additional parameter that references a hardware measurement accumulator. This change allows the methods to bypass the standard rate limiting check when the associated operation is identified as disposable based on the hardware measurement data. Additionally, a previously existing comment regarding non-billable delete operations has been removed from the cleanup function. The updates to both the method signatures and the calling sites ensure that the new parameter is consistently used across the codebase.

Possibly related PRs

Suggested reviewers

  • timvisee
  • JojiiOfficial
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ba47bb and d714cbd.

📒 Files selected for processing (3)
  • lib/collection/src/collection/clean.rs (0 hunks)
  • lib/collection/src/shards/replica_set/mod.rs (2 hunks)
  • lib/collection/src/shards/replica_set/update.rs (2 hunks)
💤 Files with no reviewable changes (1)
  • lib/collection/src/collection/clean.rs
🔇 Additional comments (4)
lib/collection/src/shards/replica_set/update.rs (2)

58-58: Added hardware measurement context to rate limiting check

The update correctly passes the hardware measurement accumulator to the rate limiter check, allowing operations to bypass rate limiting when tagged as disposable (during resharding).

301-311: Updated rate limiter to consider hardware measurement context

The method now passes the hardware measurement accumulator to the lazy rate limiter check instead of just a closure. This change correctly implements the ability to bypass rate limiting during resharding operations while keeping the existing logic for determining rate limiter cost based on the operation.

lib/collection/src/shards/replica_set/mod.rs (2)

798-814: Added ability to bypass rate limiting for resharding operations

The check_write_rate_limiter method has been updated to include a hardware measurement accumulator parameter and now bypasses rate limiting for operations tagged as disposable. This is a clean implementation that allows resharding shard cleaning operations to proceed without being rate-limited, as intended in the PR objectives.

821-833: Enhanced lazy rate limiter check with hardware measurement context

The check_write_rate_limiter_lazy method has been updated to accept a hardware measurement accumulator and only applies rate limiting if the operation is not disposable. The code is cleaner than checking for disposable operations after evaluating the cost function, as it avoids unnecessary cost calculation entirely.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@agourlay agourlay merged commit 221f2fd into dev Mar 11, 2025
17 checks passed
@agourlay agourlay deleted the no-rate-limit-resharding-shard-cleaning branch March 11, 2025 10:21
This was referenced Mar 11, 2025
Merged
Merged
timvisee pushed a commit that referenced this pull request Mar 21, 2025
@agourlay @timvisee
Do not rate limit resharding shard cleaning (#6121)
92b9d11
@timvisee timvisee mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

@JojiiOfficial JojiiOfficial JojiiOfficial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Rate limiting
Development

Successfully merging this pull request may close these issues.
3 participants
@agourlay @timvisee @JojiiOfficial