Skip to content

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Feb 27, 2025

The exact count at the start of stream records transfers may be expensive, and can time out.

As a side effect our transfer ETA estimation might be a bit off. But that's totally worth it versus potentially timing out instead.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@generall generall merged commit bc716f0 into dev Feb 27, 2025
17 checks passed
@generall generall deleted the shard-transfer-no-exact-count branch February 27, 2025 09:50
timvisee added a commit that referenced this pull request Mar 21, 2025
* Do not use exact count at beginning of shard transfer, may be expensive

* When reporting transferred records, take max of transferred and total
@timvisee timvisee mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants