Keep initial shard configuration on failed restore #6038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #6020
This PR makes sure that a failed snapshot restore does not prevent the service from restarting.
This is achieved by performing two things:
Not deleting the shard folder pleases the
ShardHolder
which expects one folder per shard.Without a WAL found for the shard, it is turned into a
DummyShard
at load time.More importantly, keeping the shard configuration provides the latest valid
replica_state.json
to access the remote shards.Concerning the crash safety, a file flag is created before the shard restore and deleted afterwards.
The presence of a flag at startup means that either:
When starting up, the presence of the flag is used to delete the potentially corrupted segments data and WAL.
This dummy shard can be the target of a new snapshot restore OR manual shard replication to fix it.
There is an E2E integration test that generates a corrupted snapshot to prove the existence of the flag, the correct startup of the service and the recovery of the shard.