Skip to content

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Feb 18, 2025

We forgot to include ClusterMetadata into Raft snapshots. Oops. This PR fixes this.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@KShivendu KShivendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests for this?

@timvisee
Copy link
Member

I'll add a test for it, but I'll do that in a separate PR to attempt to cover consensus WAL compaction in general.

@timvisee timvisee merged commit 1615a79 into dev Feb 18, 2025
17 checks passed
@timvisee timvisee deleted the raft-snapshot-cluster-metadata branch February 18, 2025 13:56
@timvisee
Copy link
Member

Basic test in #6017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants