Consider filter cardinality in write ratelimiter for update-by-filter requests #5729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
reviewed
Jan 5, 2025
tests/openapi/test_strictmode.py
Outdated
| ) | ||
| assert response.status_code == 429 | ||
| assert "Rate limiting exceeded: Write rate limit exceeded, retry later" in response.json()['status']['error'] |
There was a problem hiding this comment.
Considering that we are assigning different rate limits to different operations, this information should be represented in the response error. Something like operation require X units, but Y availble, otherwise it would be confusing to debug
generall
reviewed
Jan 5, 2025
lib/collection/src/operations/mod.rs
Outdated
| @@ -180,6 +180,40 @@ impl CollectionUpdateOperations { | |||
| Self::FieldIndexOperation(_) => (), | |||
| } | |||
| } | |||
|
|
|||
| pub fn filter(&self) -> Option<&Filter> { | |||
There was a problem hiding this comment.
We already have this
Which might be both: a better fit (cause also includes points, which we need to count as individual updates as well), and require some upgrade, cause we might not want to clone Filter
There was a problem hiding this comment.
This operation effect area is only used in ProxyShard, but ProxyShard itself is not used anywhere, so, if needed, we can change some stuff in the signatures if needed
generall
approved these changes
Jan 8, 2025
agourlay
approved these changes
Jan 8, 2025
timvisee
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Consider filter-cardinality as cost in update ratelimiter * Use OperationEffectArea and improve rate limit error message * Clippy * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.