-
Notifications
You must be signed in to change notification settings - Fork 42
refactor(lexer): remove StringOrTemplate enum
#1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 5bdd835Click to view benchmark
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jul 6, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | minor | `v0.27.0` -> `v0.28.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>quarylabs/sqruff (quarylabs/sqruff)</summary> ### [`v0.28.0`](https://github.com/quarylabs/sqruff/releases/tag/v0.28.0) [Compare Source](quarylabs/sqruff@v0.27.0...v0.28.0) #### What's Changed - refactor: remove `SqlError` trait by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1693 - refactor(parser): make `Ref::keyword` allocation-free by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1692 - fix: Implement LookaheadExclude to resolve T-SQL WITH keyword parsing issue by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1675 - refactor(logging): replace tracing with log + fern backend by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1671 - refactor(linter): remove unused last\_fixes variable and redundant sanity checks in linting process by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1696 - fix: Handle T-SQL APPLY clauses in JoinClauseSegment to prevent panic by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1695 - refactor(lexer): remove `StringOrTemplate` enum by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1703 - refactor(parser): remove helpers module and integrate validation directly in parser by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1702 - refactor(errors): remove `ValueError` by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1701 - fix: Support CTEs with Merge by [@​NormallyGaussian](https://github.com/NormallyGaussian) in quarylabs/sqruff#1700 - fix: Prevent ST04 from removing simple ELSE clauses in CASE statements by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1704 - fix: Comprehensive T-SQL parser and rule fixes for operators, CREATE statements, and multi-line constructs by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1698 - docs: updating contributing by [@​NormallyGaussian](https://github.com/NormallyGaussian) in quarylabs/sqruff#1699 - chore: update rust and tackle lint errors by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1705 - feat: add Snowflake ASOF join fixtures by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1643 - feat: back quotes in clickhouse by [@​DamianMaslanka5](https://github.com/DamianMaslanka5) in quarylabs/sqruff#1715 - Revert "fix: Comprehensive T-SQL parser and rule fixes for operators, CREATE statements, and multi-line constructs" by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1718 - fix: tsql not double wrapping statements by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1720 - refactor: clean up and optimize lint pipeline logic by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1694 - fix: cv07 working in tsql by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1721 - chore: enable working tsql rules by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1722 - chore: add test for keywords: upper and functions: lower by [@​DamianMaslanka5](https://github.com/DamianMaslanka5) in quarylabs/sqruff#1717 - chore: further tsql tests activate by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1723 - chore: bump indexmap from 2.9.0 to 2.10.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1724 - chore: update node dependencies by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1733 - chore: bump minijinja from 2.10.2 to 2.11.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1725 - chore: bump ncipollo/release-action from 1.16.0 to 1.18.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1727 - chore: bump Swatinem/rust-cache from 2.7.8 to 2.8.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1731 - docs: add CLAUDE.md for Claude Code guidance by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1736 - refactor: simplify `Dialect::add` method by removing unnecessary `Clone` bound by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1739 - fix: SQL Server syntax for identifiers ending with # in T-SQL (RF05) by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1735 - chore(cli): disable publishing for bench binary by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1742 - refactor: use lazy instantiation for NodeMatcher by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1740 - chore: make binaries more portable by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1744 - chore: publish new version by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1745 #### New Contributors - [@​NormallyGaussian](https://github.com/NormallyGaussian) made their first contribution in quarylabs/sqruff#1700 - [@​DamianMaslanka5](https://github.com/DamianMaslanka5) made their first contribution in quarylabs/sqruff#1715 **Full Changelog**: quarylabs/sqruff@v0.27.0...v0.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.