refactor(rules): extract crawl logic into standalone functions #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 3ef0dcbClick to view benchmark
|
|
Do you have any view as to why everything got slower? |
|
Since merge #1554, performance has significantly decreased (Execution took: 332.133794ms on that PR). |
|
Yep I had to do that painful fix to get the python stuff working. |
|
I don't have these issues locally, so it's possible that GitHub Actions is just under heavy load? |
|
It seems that #1561 fixes the problem, and the numbers are more convincing again. |
|
No, they’re still too noisy. Maybe we should run it at the very end—after everything else—and report the average over N runs. |
65ee394 to
89c8a87
Compare
Benchmark for c717b8aClick to view benchmark
|
Benchmark for 33b887fClick to view benchmark
|
Benchmark for f115be5Click to view benchmark
|
benfdking
approved these changes
Jun 21, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 23, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | patch | `v0.26.6` -> `v0.26.8` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>quarylabs/sqruff (quarylabs/sqruff)</summary> ### [`v0.26.8`](https://github.com/quarylabs/sqruff/releases/tag/v0.26.8) [Compare Source](quarylabs/sqruff@v0.26.7...v0.26.8) #### What's Changed - ci: improve ci cancellation by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1666 - fix: fix open vsx release by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1667 - chore: bump version by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1668 **Full Changelog**: quarylabs/sqruff@v0.26.7...v0.26.8 ### [`v0.26.7`](https://github.com/quarylabs/sqruff/releases/tag/v0.26.7) [Compare Source](quarylabs/sqruff@v0.26.6...v0.26.7) #### What's Changed - fix: lt08 leading comma panic by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1585 - chore: bump typescript-eslint from 8.33.1 to 8.34.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1649 - chore: bump [@​types/react](https://github.com/types/react) from 19.1.6 to 19.1.8 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1651 - chore: bump clap from 4.5.39 to 4.5.40 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1656 - chore: bump pyo3 from 0.25.0 to 0.25.1 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1654 - chore: bump react-resizable-panels from 3.0.2 to 3.0.3 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1653 - chore: bump [@​playwright/test](https://github.com/playwright/test) from 1.52.0 to 1.53.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1650 - chore: bump serde\_with from 3.12.0 to 3.13.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1655 - chore: bump actions/attest-build-provenance from 2.3.0 to 2.4.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1647 - chore: bump stefanzweifel/git-auto-commit-action from 5.2.0 to 6.0.1 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1648 - chore: tailwind update by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1641 - chore: remove jemalloc by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1659 - feat(clickhouse): add distinct on functionality by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1660 - chore: bump tailwindcss from 3.4.17 to 4.1.10 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1652 - refactor(rules): extract crawl logic into standalone functions by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1559 - chore: update cargo deps by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1662 - chore: update node dependencies by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1663 - ci: deploy extension to vsx by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1661 - chore: bump package version by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1665 **Full Changelog**: quarylabs/sqruff@v0.26.6...v0.26.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.