Skip to content

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Jun 16, 2023

labels: ["release-note/not-required"]

Read the code

internal/provisioner/objects/dataplane/dataplane.go
func desiredContainers(contour *model.Contour, contourImage, envoyImage string) ([]corev1.Container, []corev1.Container) {
containers := []corev1.Container{
		{
			Name:            ShutdownContainerName,
			Image:           contourImage,
			ImagePullPolicy: corev1.PullIfNotPresent,
			Command: []string{
				"/bin/contour",
			},
			Args: []string{
				"envoy",
				"shutdown-manager",
			},
		},
		{
			Name:            EnvoyContainerName,
			Image:           envoyImage,
			ImagePullPolicy: corev1.PullIfNotPresent,
			Command: []string{
				"envoy",
			},
			Args: []string{
				"-c",

The Gateway install is the same with the Yaml install.

 kubectl apply -f https://projectcontour.io/quickstart/contour.yaml

So the Envoy pod maybe the 2/2 in status


@yanggangtony yanggangtony requested a review from a team as a code owner June 16, 2023 16:46
@yanggangtony yanggangtony requested review from stevesloka and sunjayBhatia and removed request for a team June 16, 2023 16:46
Signed-off-by: yanggang <gang.yang@daocloud.io>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jun 17, 2023
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #5490 (a7676a4) into main (bf5cb53) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5490   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files         138      138           
  Lines       18799    18799           
=======================================
  Hits        14717    14717           
  Misses       3798     3798           
  Partials      284      284           

@skriss skriss merged commit c27d612 into projectcontour:main Jun 20, 2023
@yanggangtony
Copy link
Contributor Author

Thanks.

@yanggangtony yanggangtony deleted the doc-envoy-num branch June 20, 2023 22:03
shadialtarsha pushed a commit to shadialtarsha/contour that referenced this pull request Jun 22, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants