-
Notifications
You must be signed in to change notification settings - Fork 36
Fix/nightly ci #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/nightly ci #497
Conversation
Seems reasonable. |
21e6a9f
to
7d6ce94
Compare
So it looks like this doesn't work as intended. I made the nightly workflow run on PR in the top most commit. Both of those show in their test output:
Further investigation shows that I had SLOW_TESTS (plural) in the workflow 'env' while the code is looking at SLOW_TEST (singular). Change made, pushed, lets see. After this runs i have to still drop the top-most commit so that nightly doesn't run on PR. |
1ffe228
to
7b76be8
Compare
run: | | ||
make check | ||
build: | ||
uses: ./.github/workflows/build.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is "slow-test" actually set to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is "slow-test" actually set to true?
It defaults to true. (.github/workflows/build.yaml).
it seems that "run all the tests" is a better default. That way in a release and in a nightly we get all the tests run. the only place we don't get them all run is in the 'ci.yaml' caller.
7b76be8
to
b8d4039
Compare
The build workflow was being 'used' by callers in ci and release. Here also make 'nightly' a caller. Additionally, * add 'slow-test' input to build.yaml, defaulting to true. Set that to false in ci.yaml so we do not run the slow tests on all PRs. slow-test value gets put into environment variable SLOW_TEST which is read by the test harness. * make build-id a scalar, not an array. * move build-id out of matrix (it is a constant) and reference it as an input instead. * Provide default values for 'privilege-level' and 'go-version' in build.yaml so the callers do not have to specify those. Note that we still *do* specify the privilege-level and go-version in a release build. This is, I believe, because we want a consistent thing that gets restored in the cache. It is unfortunate, but as a result, we aren't testing with unpriv during a release build. Signed-off-by: Scott Moser <smoser@brickies.net>
f69a108
to
7a66c8a
Compare
both of the slow test runs failed. see here.
maybe the 'mount + umount' failure is unrelated as it normally passes, but the other failure is in a test marked slow. |
I'd like to ask that this be landed. nightly c-i will still be broken, but this PR gets us closer. |
This is an attempt at fixing nightly c-i similar to #496
but with more re-use and building more nightkly.