ci: fix nightly workflow #496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
940bc7b to
397016f
Compare
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
|
Could you run the nightly workflow on this branch before we land it? i think what you'd have to do is:
|
smoser
reviewed
Sep 6, 2023
There was a problem hiding this comment.
I don't think this will work as is.
You added the 'checkout' action, which is good, but I think you still need to Setup Environment and 'install dependencies' and 'go-download'...
I think what we want from a nightly job is basically to run the same c-i as we do on PR, but with the additional enviroment variable SLOW_TEST set.
Merged
|
I put up a PR that does this differently at #497 |
|
Closing this in favor of PR #497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.