Fix race condition in stacker's squashfuse mount path. #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71d38db to
c12d328
Compare
hallyn
approved these changes
Mar 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 12.12% 12.08% -0.05%
==========================================
Files 44 44
Lines 5433 5451 +18
==========================================
Hits 659 659
- Misses 4657 4675 +18
Partials 117 117
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Why was test ' @github-actions ci / build / golang 1.20.x privilege unpriv (pull_request' skipped? |
|
part of the build (test) timed out https://github.com/project-stacker/stacker/actions/runs/4318221259/jobs/7554679260 |
1cbf125 to
2998625
Compare
squashfuse from Ubuntu 22.04 is linked to fuse2 and has some bugs compared to one that is linked against fuse3. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025706 Signed-off-by: Scott Moser <smoser@brickies.net>
This protection was present in one of the callers of squashFuse, but not in another. The change here just to put them inside squashFuse. Fixes project-stacker#428. Signed-off-by: Scott Moser <smoser@brickies.net>
2998625 to
c546498
Compare
hallyn
approved these changes
Mar 7, 2023
smoser
pushed a commit
to project-machine/bootkit
that referenced
this pull request
Mar 10, 2023
This is to work around a bug in stacker. project-stacker/stacker#431 Until that is fixed, we are getting errors during build where the 'run' section tries to use 'pkgtool' before that layer has been populated.
smoser
pushed a commit
to project-machine/bootkit
that referenced
this pull request
Mar 10, 2023
This is to work around a bug in stacker. project-stacker/stacker#431 Until that is fixed, we are getting errors during build where the 'run' section tries to use 'pkgtool' before that layer has been populated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protection was present in one of the callers of squashFuse, but not in another. The change here just to put them inside squashFuse.
Fixes #428.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.