Move from golang.org/x/exp/slices into slices #13403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@machine424 Could you rebase this? |
|
rebased. |
7a5cfe2 to
4658682
Compare
|
It has merge conflicts again, but only in go.mod. Could you address them once more? I'll try to merge quickly after that. |
beorn7
approved these changes
Feb 28, 2024
…t Go >= 1.21 Prevent adding back golang.org/x/exp/slices. Signed-off-by: machine424 <ayoubmrini424@gmail.com>
|
done |
|
thank you |
duricanikolic
added a commit
to grafana/mimir-prometheus
that referenced
this pull request
Mar 6, 2024
This completes prometheus/prometheus#13403 Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent adding back golang.org/x/exp/slices.
"slices" was introduced in golang 1.21
Only merge once Prometheus only supports >= go1.21