[wlog/watcher] read segment synchronously when not tailing #13224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlevesy can you add a changelog entry, imo this is an enhancement |
Signed-off-by: Julien Levesy <jlevesy@gmail.com>
514421d to
ba65ab5
Compare
|
Done! |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
cstyan
added a commit
that referenced
this pull request
Dec 5, 2023
Signed-off-by: Julien Levesy <jlevesy@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes
wlog.Watcherreplays segments synchronously when not tailing.It adds a test that proves replaying a fixed amount of segments takes less time than a single timeout.
Relates to #13111
Supersedes #13188