Support including scope metadata as metric labels #16878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
dashpole
reviewed
Jul 16, 2025
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
dashpole
approved these changes
Jul 18, 2025
dashpole
approved these changes
Jul 18, 2025
|
I'm taking the liberty to merge with a single approval since I'm just re-introducing something that was approved by others before! |
tcp13equals2
pushed a commit
to tcp13equals2/prometheus
that referenced
this pull request
Aug 18, 2025
* Support including scope metadata as metric labels Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> * Ensure Scope Name, Version and Schema URL aren't overriden by attributes Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Andrew Hall <andrew.hall@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce #16730 and #16760, which were reverted in #16842.
After further discussions in open-telemetry/semantic-conventions#2489, a scope shouldn't have attributes called
name,version, orschema_url, so the collision should not happen.