config: Add UnderscoreEscapingWithoutSuffixes translation strategy #16849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last permutation of the translation options does underscore translation but does not add suffixes. This translation option already exists in Mimir as otel_metric_suffixes_enabled, indicating external demand for this strategy. There is an accompanying update to prometheus-docs to explain the use of this mode: prometheus/docs#2688 Signed-off-by: Owen Williams <owen.williams@grafana.com>
dc4b1ab to
f0c7b84
Compare
Signed-off-by: Owen Williams <owen.williams@grafana.com>
|
Confirmed that mimir also uses the same settings struct so once they migrate to latest prom/otlptranslator the functionality will be identical: https://github.com/grafana/mimir/blob/main/pkg/distributor/otel.go#L278 |
ywwg
added a commit
to prometheus/docs
that referenced
this pull request
Jul 11, 2025
…xes translation strategy (#2688) ref: prometheus/prometheus#16849 Signed-off-by: Owen Williams <owen.williams@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last permutation of the translation options does underscore translation but does not add suffixes. This translation option already exists in Mimir as otel_metric_suffixes_enabled, indicating external demand for this strategy. There is an accompanying update to prometheus-docs to explain the use of this mode: prometheus/docs#2688