Skip to content

mantine-ui: add query warnings display to graph view #16753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

mantine-ui: add query warnings display to graph view #16753

merged 1 commit into from
Jun 19, 2025

Conversation

roidelapluie
Copy link
Member

image

@roidelapluie roidelapluie requested a review from juliusv as a code owner June 19, 2025 10:05
@roidelapluie
mantine-ui: add query warnings display to graph view
8dcb0ba 
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
jesusvazquez
jesusvazquez approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roidelapluie roidelapluie merged commit 76a97ca into prometheus:main Jun 19, 2025
27 checks passed
@juliusv
Copy link
Member

juliusv commented Jun 19, 2025

Was it intentional to only show warnings and not info-level annotations as we do in the Table view?

I just was looking at the Table code for that again in

prometheus/web/ui/mantine-ui/src/pages/query/TableTab.tsx

Lines 102 to 122 in 76a97ca

{data.warnings?.map((w, idx) => (
<Alert
key={idx}
color="red"
title="Query warning"
icon={<IconAlertTriangle />}
>
{w}
</Alert>
))}
{data.infos?.map((w, idx) => (
<Alert
key={idx}
color="yellow"
title="Query notice"
icon={<IconInfoCircle />}
>
{w}
</Alert>
))}
and now also wondering why I didn't show both in the Graph tab already. Maybe I just forgot about it while building both :)

@charleskorn charleskorn mentioned this pull request Jun 19, 2025
Merged
roidelapluie added a commit to roidelapluie/prometheus that referenced this pull request Jun 20, 2025
@roidelapluie
mantine-ui: add query info warnings display to graph view
7f2946c 
Followup of prometheus#16753

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
@roidelapluie roidelapluie mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusvazquez jesusvazquez jesusvazquez approved these changes

@juliusv juliusv Awaiting requested review from juliusv juliusv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roidelapluie @juliusv @jesusvazquez