Skip to content

fix: add reproducer for a dangling-reference issue in parsers and fix #16623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

fix: add reproducer for a dangling-reference issue in parsers and fix #16623

merged 2 commits into from
May 27, 2025

Conversation

machine424
Copy link
Member

@machine424 machine424 commented May 21, 2025 •
edited
Loading

fixes #16490

partially reverts #16012

We'd need to backport this to 3.4

machine424
machine424 commented May 21, 2025
View reviewed changes
machine424
machine424 commented May 21, 2025
View reviewed changes
@machine424 machine424 marked this pull request as draft May 21, 2025 22:03
@machine424
Copy link
Member Author

the data race is reproduced

     reload_test.go:194: time=2025-05-21T22:04:07.587Z level=ERROR source=db.go:1112 msg="compaction failed" component=tsdb err="2 errors: add series: symbol entry for \"ap_chunk_corruptions_total Total number of\" does not exist; series not 16-byte aligned at 13279"
    main_test.go:876: 
        	Error Trace:	/__w/prometheus/prometheus/cmd/prometheus/main_test.go:876
        	            				/usr/local/go/src/runtime/asm_amd64.s:1700
        	Error:      	Should be zero, but was 1
        	Test:       	TestHeadCompactionWhileScraping
    reload_test.go:194: time=2025-05-21T22:04:08.596Z level=ERROR source=db.go:1112 msg="compaction failed" component=tsdb err="2 errors: add series: symbol entry for \"ap_chunk_corruptions_total Total number of\" does not exist; series not 16-byte aligned at 13279"
    reload_test.go:194: time=2025-05-21T22:04:10.611Z level=ERROR source=db.go:1112 msg="compaction failed" component=tsdb err="2 errors: add series: symbol entry for \"ap_chunk_corruptions_total Total number of\" does not exist; series not 16-byte aligned at 13279"
    reload_test.go:194: time=2025-05-21T22:04:14.625Z level=ERROR source=db.go:1112 msg="compaction failed" component=tsdb err="2 errors: add series: symbol entry for \"ap_chunk_corruptions_total Total number of\" does not exist; series not 16-byte aligned at 13279"
    main_test.go:845: 
        	Error Trace:	/__w/prometheus/prometheus/cmd/prometheus/main_test.go:845
        	Error:      	Condition never satisfied
        	Test:       	TestHeadCompactionWhileScraping

@machine424 machine424 marked this pull request as ready for review May 22, 2025 07:23
@machine424 machine424 changed the title fix: add reproducer for a dangling-reference issue in parsers WIP: fix: add reproducer for a dangling-reference issue in parsers May 22, 2025
@machine424 machine424 force-pushed the reprep branch 4 times, most recently from 4c635cf to 0219dc5 Compare May 22, 2025 12:44
machine424 added 2 commits May 22, 2025 17:22
@machine424
fix: add reproducer for a dangling-reference issue in parsers
2bfbd8a 
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
@machine424
fix(model/textparse): Labels(): copy the input to avoid dangling refe…
50a6efd 
…rences

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
machine424
machine424 commented May 23, 2025
View reviewed changes
machine424
machine424 commented May 23, 2025
View reviewed changes
@machine424 machine424 changed the title WIP: fix: add reproducer for a dangling-reference issue in parsers fix: add reproducer for a dangling-reference issue in parsers May 23, 2025
machine424
machine424 commented May 23, 2025
View reviewed changes
@machine424 machine424 requested a review from bboreham May 23, 2025 09:44
@machine424 machine424 mentioned this pull request May 23, 2025
Closed
@machine424 machine424 changed the title fix: add reproducer for a dangling-reference issue in parsers fix: add reproducer for a dangling-reference issue in parsers and fix May 23, 2025
@ArthurSens ArthurSens mentioned this pull request May 26, 2025
Merged
1 task
@machine424 machine424 merged commit 44f78bb into prometheus:main May 27, 2025
27 checks passed
@machine424 machine424 mentioned this pull request May 27, 2025
Merged
@charleskorn charleskorn mentioned this pull request May 30, 2025
Merged
@fpletz fpletz mentioned this pull request Jun 1, 2025
Merged
13 tasks
@machine424 machine424 mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compaction failed, suspected data corruption issue
2 participants
@machine424 @bboreham