model/textparse: Change parser interface Metric(...) string to Labels(...) #16012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb29409 to
2bc541a
Compare
…(...) Simplified the interface given no one is using the return argument. Renamed for clarity too. Found and discussed #15731 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com>
2bc541a to
4a1085a
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
machine424
approved these changes
Feb 12, 2025
kylestang
pushed a commit
to kylestang/prometheus
that referenced
this pull request
Feb 12, 2025
…(...) (prometheus#16012) * model/textparse: Change parser interface Metric(...) string to Labels(...) Simplified the interface given no one is using the return argument. Renamed for clarity too. Found and discussed prometheus#15731 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> * Fixed comments; optimized not needed copy for om and text. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
This was referenced May 20, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the interface given no one is using the return argument. Renamed for clarity too.
Found and discussed #15731 (comment)
This is a breaking change for downstream users. We are planning more changes too for efficiency.