Skip to content

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented May 16, 2025

With golangci-lint v2, it now has "formatters" that can be configured. Add golangci-lint fmt to the make format in Makefile.common.

  • Enable goimports formatter.

@SuperQ SuperQ requested a review from machine424 May 16, 2025 08:10
@SuperQ SuperQ force-pushed the superq/golangci-lint-fmt branch from cb6bf66 to eb0686d Compare May 16, 2025 08:20
@SuperQ SuperQ requested a review from brancz as a code owner May 16, 2025 08:20
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SuperQ
Copy link
Member Author

SuperQ commented May 16, 2025

Gah, gci and goimports disagree on the formatting of imports in discovery/kubernetes/kubernetes.go.

With golangci-lint v2, it now has "formatters" that can be configured.
Add `golangci-lint fmt` to the `make format` in Makefile.common.
* Enable goimports formatter.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ force-pushed the superq/golangci-lint-fmt branch from eb0686d to 8254e2a Compare May 16, 2025 08:33
@SuperQ SuperQ merged commit 1eaf12e into main May 16, 2025
45 checks passed
@SuperQ SuperQ deleted the superq/golangci-lint-fmt branch May 16, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants